Validators for JSON and Graphql Exporter #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishi-aga
force-pushed
the
tableExportValidator
branch
3 times, most recently
from
e6743cc
to
3ae6b3d
Compare
rishi-aga
force-pushed
the
tableExportValidator
branch
from
3ae6b3d
to
729652b
Compare
aklish
requested changes
Feb 12, 2021
|
|
||
| private static final Validator INSTANCE = new NoRelationshipsProjectionValidator(); | ||
|
|
||
| public static Validator getInstance() { |
| } | ||
|
|
||
| @Test | ||
| public void testProcessMultipleQuery() { |
There was a problem hiding this comment.
How is this test different than the one above it?
There was a problem hiding this comment.
this one has 2 queries with single projection and other one has single query with more than one projection
| @@ -41,7 +41,8 @@ | |||
|
|
|||
| public GraphQLTableExportOperation(TableExportFormatter formatter, AsyncExecutorService service, | |||
| AsyncAPI export, RequestScope scope, ResultStorageEngine engine) { | |||
| super(formatter, service, export, scope, engine); | |||
| super(formatter, service, export, scope, engine, | |||
| Arrays.asList(NoRelationshipsProjectionValidator.getInstance())); | |||
There was a problem hiding this comment.
It seems like both need the same validators. Should we move the NoRelationshipsProjectionValdator to the super class list?
There was a problem hiding this comment.
Single SingleRootProjectionValidator is must as I am taking first one from collection in call method, so kept it in superclass. NoRelationshipsProjectionValdator could be optional for any new subclass.
rishi-aga
force-pushed
the
tableExportValidator
branch
from
729652b
to
c503c06
Compare
aklish
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validators for JSON and Graphql Exporter
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.